fix: added bulk_action_ref for changeset lookups#645
Closed
DGollings wants to merge 1 commit intoash-project:mainfrom
Closed
fix: added bulk_action_ref for changeset lookups#645DGollings wants to merge 1 commit intoash-project:mainfrom
DGollings wants to merge 1 commit intoash-project:mainfrom
Conversation
7 tasks
zachdaniel
reviewed
Nov 9, 2025
| if options[:return_records?] do | ||
| {:ok, AshSql.Query.remap_mapped_fields(results, query)} | ||
| results = AshSql.Query.remap_mapped_fields(results, query) | ||
| {:ok, Enum.map(results, &add_bulk_metadata(&1, changeset))} |
Contributor
There was a problem hiding this comment.
For update_query and destroy_query this part doesn't really make much sense actually 🤔 So maybe it can really just be left out of here and can just be done in ash core when its iteratively doing the work. Also, don't we need to switch the bulk create logic to use refs now?
Contributor
There was a problem hiding this comment.
Actually I guess it does make sense because update & destroy just call update_query/destroy... 🤔 I'm trying to determine if these are even strictly necessary. It may be only bulk creates that need to return their indexes? I will look into it 😄
Contributor
|
Okay, all thats necessary is updating the bulk create logic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Leave anything that you believe does not apply unchecked.